Skip to content

debugger: fix TypeError of list command in inspector repl #42776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2022
Merged

debugger: fix TypeError of list command in inspector repl #42776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e45af10
debugger: throw debugger error when the frame is missing
cola119 Apr 20, 2022
832435f
test: fix flaky test
cola119 Apr 20, 2022
88f48e0
test: refactor into async-await
cola119 Apr 20, 2022
4cbbd47
test: fix flaky test
cola119 Apr 22, 2022
2ac7da0
test: fix newline characters
cola119 Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/internal/debugger/inspect_repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,9 @@ function createRepl(inspector) {

// List source code
function list(delta = 5) {
if (!selectedFrame) {
throw new ERR_DEBUGGER_ERROR('Requires execution to be paused');
}
return selectedFrame.list(delta).then(null, (error) => {
print("You can't list source code right now");
throw error;
Expand Down
30 changes: 30 additions & 0 deletions test/sequential/test-debugger-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict';
const common = require('../common');

common.skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/debugger');

const assert = require('assert');

const cli = startCLI([fixtures.path('debugger/three-lines.js')]);

(async () => {
await cli.waitForInitialBreak();
await cli.waitForPrompt();
await cli.command('list(0)');
assert.match(cli.output, /> 1 let x = 1;/);
await cli.command('list(1)');
assert.match(cli.output, /> 1 let x = 1;\r?\n {2}2 x = x \+ 1;/);
await cli.command('list(10)');
assert.match(cli.output, /> 1 let x = 1;\r?\n {2}2 x = x \+ 1;\r?\n {2}3 module\.exports = x;\r?\n {2}4 /);
await cli.command('c');
await cli.waitFor(/disconnect/);
await cli.waitFor(/debug> $/);
await cli.command('list()');
await cli.waitFor(/ERR_DEBUGGER_ERROR/);
assert.match(cli.output, /Uncaught Error \[ERR_DEBUGGER_ERROR\]: Requires execution to be paused/);
})()
.finally(() => cli.quit())
.then(common.mustCall());