-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
src: add --openssl-legacy-provider option #40478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Neither this PR nor #40466 load the legacy provider by default, and I think that makes sense. While these PRs make the legacy provider available, this will not unbreak npm. |
I agree about not being the default making sense -- this option should be intended to be used as a stop-gap until dependencies can be updated to migrate away from the weaker crypto algorithms. |
This commit add the missing legacy provider source code which is requried for statically linking the OpenSSL legacy provider. Co-authored-by: Richard Lau <[email protected]>
Co-authored-by: Richard Lau <[email protected]>
This commit adds an option to Node.js named --openssl-legacy-provider
and if specified will load OpenSSL 3.0 Legacy provider.
$ ./node --help
...
--openssl-legacy-provider enable OpenSSL 3.0 legacy provider
Example usage:
$ ./node --openssl-legacy-provider -p 'crypto.createHash("md4")'
Hash {
_options: undefined,
[Symbol(kHandle)]: Hash {},
[Symbol(kState)]: { [Symbol(kFinalized)]: false }
}
Co-authored-by: Richard Lau <[email protected]>
Refs: nodejs#40455
415743a to
86d1c0c
Compare
|
@tniessen @targos @RaisinTen @BethGriggs @mhdawson I would be great if we could get this PR merged today and into the Node.js 17 release tomorrow. Would one or more of you be able to review? |
Update link and link text.
|
Should this work now with node16? In our use case it woudl be enough if it just doesn't fail with an error message, as we need this flag for all our devs that are on node 16+, but we can't add it for all that are still on node 16 |
|
I also have the same issue with
|
|
@mshabarov what is your output of |
|
@BethGriggs my output is |
This commit adds an option to Node.js named
--openssl-legacy-providerandif specified will load OpenSSL 3.0 Legacy provider.
Example usage:
Co-authored-by: Richard Lau [email protected]
Refs: #40455
This is an alternative to the suggestion in #40466