timers: allow passing delay to timer.refresh() #40434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
timers
This comment has been minimized.
This comment has been minimized.
mscdex
force-pushed
the
timers-refresh-args
branch
from
7ddac5c to
10d58e7
Compare
This comment has been minimized.
This comment has been minimized.
mscdex
force-pushed
the
timers-refresh-args
branch
from
10d58e7 to
18ddfd5
Compare
This comment has been minimized.
This comment has been minimized.
mscdex
force-pushed
the
timers-refresh-args
branch
from
18ddfd5 to
b959c50
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
@nodejs/timers |
mscdex
force-pushed
the
timers-refresh-args
branch
from
b959c50 to
29f5a66
Compare
Collaborator
juanarbol
approved these changes
Oct 13, 2021
This was referenced Oct 14, 2021
Member
|
@mscdex ... can I ask you to provide a short change description and rationale? |
jasnell
approved these changes
Oct 20, 2021
benjamingr
previously requested changes
Oct 21, 2021
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
I'd like to know why/for what this is useful before this is merged?
Like - I know there is probably a reasonable use case for this but I don't know what it is
Contributor
Author
|
@benjamingr In my particular case I have a queue of waiting tasks, each with varying start timestamps. With the changes in this PR I can reuse a single timer object for the entire queue and simply do something like |
mscdex
force-pushed
the
timers-refresh-args
branch
2 times, most recently
from
a4510d4 to
efff092
Compare
mscdex
force-pushed
the
timers-refresh-args
branch
from
efff092 to
1ae03a2
Compare
Collaborator
targos
added
the
semver-minor
mscdex
force-pushed
the
timers-refresh-args
branch
from
1ae03a2 to
4ed6584
Compare
Collaborator
Contributor
Author
|
@jasnell I'm not sure what you're asking for. Were you just interested in hearing a use case like @benjamingr ? |
This was referenced Apr 28, 2022
Contributor
|
This needs a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.