Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jul 26, 2021

Update emails to correspond to what is specified in .mailmap and what is used in recently authored commits.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 26, 2021
Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like to use the old email address since maybe I will leave this company in the next month

Trott added 2 commits July 25, 2021 22:15
Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.
@Trott
Copy link
Member Author

Trott commented Jul 26, 2021

i would like to use the old email address

OK, I restored that email address to README and also made it the email used in AUTHORS (by updating .mailmap). PTAL

Copy link
Member

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2021
@github-actions
Copy link
Contributor

Landed in 31e8c63...b14fb01

@github-actions github-actions bot closed this Jul 28, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 28, 2021
Update email for Zeyu Yang.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jul 28, 2021
Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jul 28, 2021
Update email for Ujjwal Sharma.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Update email for Zeyu Yang.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Update email for Ujjwal Sharma.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
Update email for Zeyu Yang.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
Update email for Shelley Vohr to correspond to what is specified in
.mailmap and what is used in more recently authored commits.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
Update email for Ujjwal Sharma.

PR-URL: #39521
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott deleted the last-updates branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants