v12.22.4 proposal #39500
Merged
v12.22.4 proposal #39500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main goal of using a GitHub Action for labelling PRs has been to move the mapping between files changed -> label into a configuration file local to the nodejs/node repository. Previously any changes to that mapping meant having to grasp the nodejs/github-bot project, open a PR with the neccessary changes, get approval from its maintainers before those changes finally got pushed to production. The logic involved in using the file paths / label configuration and resolving the labels to be applied, has been moved into a custom GitHub Action project: nodejs/node-pr-labeler. Aside from removing the external dependency the nodejs-github-bot is in practise, it also reduces the bar for contributors since the resulting project is a lot smaller and less complex than nodejs/github-bot. PR-URL: #38301 Fixes: nodejs/github-bot#294 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #38399 Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Original commit message: ``` PPC: Add Power10 to the supported list and enable related features This CL adds Power10 recognition to Linux, AIX as well as IBMi. Enabled features include: MODULO FPR_GPR_MOV SIMD LWSYNC ISELECT VSX Change-Id: Ifc337e6497a3efe9697bcf03063a2b94471f96e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2855041 Reviewed-by: Clemens Backes <[email protected]> Reviewed-by: Junliang Yan <[email protected]> Reviewed-by: Vasili Skurydzin <[email protected]> Commit-Queue: Milad Fa <[email protected]> Cr-Commit-Position: refs/heads/master@{#74279} ``` Refs: v8/v8@530080c PR-URL: #38509 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Original commit message:
tracing: Update proto library build rule and roll Perfetto
This patch removes use of the deprecated sources_assignment_filter GN
feature from gni/proto_library.gni, since the extra descriptor files are
no longer being generated.
We also roll Perfetto to match the version used in Chrome and update
test expectations accordingly.
Bug: v8:10995
Change-Id: I65cb3b79feb6e5a7e5c8d99fdb8bf999a6048539
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2454079
Commit-Queue: Michael Achenbach <[email protected]>
Auto-Submit: Sami Kyöstilä <[email protected]>
Reviewed-by: Peter Marshall <[email protected]>
Reviewed-by: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/heads/master@{#70381}
Refs: v8/v8@1b1eda0
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <[email protected]>
Original commit message:
build: Remove no-op calls to set_sources_assignment_filter
Chromiun no longer use set_sources_assignment_filter() anywhere in the
build, so these are no longer needed.
Bug: chromium:1018739
Change-Id: I7b33612d925563ebca0d93a7d3c9183d7305b7b0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2456988
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/master@{#70405}
Refs: v8/v8@92e6d33
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <[email protected]>
Original commit message:
[build] Remove jumbo build configs
Bug: chromium:994387
Change-Id: I7b37a416ce6cc79903fe04923e86af1d0065ac37
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890090
Reviewed-by: Maya Lekova <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/heads/master@{#64669}
Refs: v8/v8@e6f62a4
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <[email protected]>
Original commit message:
[build] Move split_static_library.gni from Chromium repo
We'll remove the file from Chromium in a follow up after V8 has rolled
+ 2 days.
Bug: v8:9911
Change-Id: I69fe56855f1ba83bec0d39e0fb6acb7e4182c6b7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1897826
Reviewed-by: Nico Weber <[email protected]>
Commit-Queue: Michael Achenbach <[email protected]>
Cr-Commit-Position: refs/heads/master@{#64742}
Refs: v8/v8@7b33328
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <[email protected]>
Original commit message:
Add a simple gclient_args.gni file to V8
Bug: v8:9914
Change-Id: I0bae9aadd89876e8505e1388903c86777694ee09
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890100
Reviewed-by: Michael Achenbach <[email protected]>
Commit-Queue: Maya Lekova <[email protected]>
Cr-Commit-Position: refs/heads/master@{#64680}
Refs: v8/v8@cc641f6
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <[email protected]>
Original commit message:
Fix visiblity rules for configs enforced by the latest GN version.
Prior versions of GN had a bug (gn:22) where visibility rules
for configs weren't being enforced properly.
This CL tweaks the visibility settings of some configs to
conform to the latest version.
Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
Commit-Queue: Dirk Pranke <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69463}
Refs: v8/v8@7c182bd
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <[email protected]>
Original commit message:
Fix implicit conversion loses integer precision warning
The type of m is long in 64 bits build, and results implicit conversion
loses integer precision, which was found by improved clang warning
(-Wshorten-64-to-32)
Bug: chromium:1124085
Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323
Commit-Queue: Zequan Wu <[email protected]>
Auto-Submit: Zequan Wu <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Reviewed-by: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69686}
Refs: v8/v8@0b3a4ec
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <[email protected]>
Original commit message:
Add -Wno-string-concatenation to test/cctest:cctest_sources
v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.
Bug: chromium:1114873
Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
Commit-Queue: Arthur Eubanks <[email protected]>
Reviewed-by: Sathya Gunasekaran <[email protected]>
Cr-Commit-Position: refs/heads/master@{#69625}
Refs: v8/v8@8959494
PR-URL: #39245
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <[email protected]>
These updates are necessary to build V8 with recent GN versions. PR-URL: #39245 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <[email protected]>
PR-URL: #37992 Backport-PR-URL: #38003 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: #38450 Backport-PR-URL: #39422 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/39245/ |
Move the `#define`s back into `cares_wrap.cc`, as they are part of the implementation, not the declarations used in `cares_wrap.h`, and apply the suggestion from #38572 (comment) to make the defines a bit more generic and not check for OpenBSD specifically. Refs: #38572 PR-URL: #38670 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
`CHECK(it->second)` asserts that we have `PerIsolatePlatformData` in the `per_isolate_` map, and not just a key with empty value. When `it == per_isolate_.end()`, however, it means that we don't have the isolate and the `CHECK(it->second)` is guaranteed to fail then! PR-URL: #38010 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Original commit message:
[Intl] call new ListFormatter::createInstance
The one we currently using is now marked as internal and to be removed
for 68. Migrating to the style which already avaiable in ICU 67-1.
Bug: v8:11031
Change-Id: I668382a2e1b8602ddca02bf231c5008a6c92bf2d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477751
Reviewed-by: Jakob Kummerow <[email protected]>
Commit-Queue: Frank Tang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#70638}
Refs: v8/v8@035c305
PR-URL: #38497
Backport-PR-URL: #39451
Reviewed-By: Jiawen Geng <[email protected]>
This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by #34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] v8/v8@611e412 [2] v8/v8@eeccede PR-URL: #39068 Backport-PR-URL: #39451 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
richardlau
force-pushed
the
v12.22.4-proposal
branch
from
9ac9229 to
b5393b1
Compare
This comment has been minimized.
This comment has been minimized.
targos
reviewed
Jul 26, 2021
Comment on lines
80
to
86
| ### Notable Changes | ||
|
|
||
| tbd | ||
|
|
Member
There was a problem hiding this comment.
I guess this can be removed if there's nothing of note
Member
Author
There was a problem hiding this comment.
There's nothing of note... yet. I've been asked to add a few more commits to this, which will be notable, but they're not ready yet.
richardlau
force-pushed
the
v12.22.4-proposal
branch
from
b5393b1 to
d08fdfb
Compare
This comment has been minimized.
This comment has been minimized.
PR-URL: #36207 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Rich Trott <[email protected]>
richardlau
force-pushed
the
v12.22.4-proposal
branch
from
d08fdfb to
86de084
Compare
Collaborator
PR-URL: #39423 Backport-PR-URL: #39527 Fixes: #38964 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
richardlau
force-pushed
the
v12.22.4-proposal
branch
from
86de084 to
bb5e9f1
Compare
Collaborator
PR-URL: #39553 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
PR-URL: #38979 Backport-PR-URL: #39497 Fixes: #32103 Fixes: #38739 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
richardlau
added a commit
that referenced
this pull request
Jul 28, 2021
Notable changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) PR-URL: #39500
richardlau
force-pushed
the
v12.22.4-proposal
branch
from
bb5e9f1 to
bbec863
Compare
This is a security release. Notable changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) PR-URL: #39500
richardlau
force-pushed
the
v12.22.4-proposal
branch
from
bbec863 to
2fdf989
Compare
Collaborator
richardlau
added a commit
that referenced
this pull request
Jul 29, 2021
This is a security release. Notable changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) PR-URL: #39500
richardlau
added a commit
to richardlau/nodejs.org
that referenced
this pull request
Jul 29, 2021
richardlau
added a commit
to richardlau/nodejs.org
that referenced
this pull request
Jul 29, 2021
richardlau
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-07-29, Version 12.22.4 'Erbium' (LTS), @richardlau
This is a security release.
Notable Changes
Commits
499e56babe] - build: fix label-pr workflow (Michaël Zasso) #3839998ac3c4108] - build: label PRs with GitHub Action instead of nodejs-github-bot (Phillip Johnsen) #38301ddc8dde150] - deps: upgrade npm to 6.14.14 (Darcy Clarke) #39553e11a862eed] - deps: update to c-ares 1.17.1 (Danny Sonnenschein) #3620739e9cd540f] - deps: restore minimum ICU version to 65 (Richard Lau) #39068e459c79b02] - deps: V8: cherry-pick 035c305ce776 (Michaël Zasso) #38497b3c698a5d8] - deps: update to [email protected] (Guy Bedford) #384507d5a2f9588] - deps: update to [email protected] (Guy Bedford) #37992906b43e586] - deps: V8: update build dependencies (Michaël Zasso) #3924515b91fa3fa] - deps: V8: backport 895949419186 (Michaël Zasso) #392458046daf09f] - deps: V8: cherry-pick 0b3a4ecf7083 (Michaël Zasso) #39245f4377b13a6] - deps: V8: cherry-pick 7c182bd65f42 (Michaël Zasso) #39245add7b5b4c2] - deps: V8: cherry-pick cc641f6be756 (Michaël Zasso) #39245a73275f056] - deps: V8: cherry-pick 7b3332844212 (Michaël Zasso) #39245492b0d6b37] - deps: V8: cherry-pick e6f62a41f5ee (Michaël Zasso) #392452b54156260] - deps: V8: cherry-pick 92e6d3317082 (Michaël Zasso) #39245bbceab4d91] - deps: V8: backport 1b1eda0876aa (Michaël Zasso) #3924593a1a3c5ae] - deps: V8: cherry-pick 530080c44af2 (Milad Fa) #38509b263f2585a] - http2: on receiving rst_stream with cancel code add it to pending list (Akshay K) #394233e4bc1b0d3] - module: fix legacynodespecifier resolution to resolve"main"field (Antoine du Hamel) #38979f552c45676] - src: move CHECK in AddIsolateFinishedCallback (Fedor Indutny) #3801030ce0e66ae] - src: update cares_wrap OpenBSD defines (Anna Henningsen) #38670