Skip to content

test: remove workaround code in debugger test #39238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021
+3 −13
Merged

test: remove workaround code in debugger test #39238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions test/sequential/test-debugger-preserve-breaks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,19 +53,9 @@ const path = require('path');
})
.then(() => cli.command('breakpoints'))
.then(() => {
// TODO: There is a known issue on AIX and some other operating systems
// where the breakpoints aren't properly resolved yet when we reach this
// point. Eventually that should be figured out but for now we don't
// want to fail builds because of it.
// What it should be:
//
// const msg = `SCRIPT: ${script}, OUTPUT: ${cli.output}`;
// assert.ok(cli.output.includes(`#0 ${script}:2`), msg);
// assert.ok(cli.output.includes(`#1 ${script}:3`), msg);
//
// What we're doing for now instead:
assert.match(cli.output, /#0 [^\n]+three-lines\.js\$?:2/);
assert.match(cli.output, /#1 [^\n]+three-lines\.js\$?:3/);
const msg = `SCRIPT: ${script}, OUTPUT: ${cli.output}`;
assert.ok(cli.output.includes(`#0 ${script}:2`), msg);
assert.ok(cli.output.includes(`#1 ${script}:3`), msg);
})
.then(() => cli.quit())
.then(null, onFatal);
Expand Down