Skip to content

Conversation

VoltrexKeyva
Copy link
Member

Added JSDoc typings for the child_process lib module.

Added JSDoc typings for the `child_process` lib module.
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Apr 13, 2021
@targos targos added the typings label Apr 13, 2021
@VoltrexKeyva VoltrexKeyva changed the title lib: add JSDoc typings for child_process typings: add JSDoc typings for child_process Apr 15, 2021
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

mhdawson pushed a commit that referenced this pull request Jun 17, 2021
Added JSDoc typings for the `child_process` lib module.

PR-URL: #38222
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member

Landed in 9d3a592

@mhdawson mhdawson closed this Jun 17, 2021
@VoltrexKeyva VoltrexKeyva deleted the patch-5 branch June 17, 2021 19:44
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jun 17, 2021
Added JSDoc typings for the `child_process` lib module.

PR-URL: nodejs#38222
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
Added JSDoc typings for the `child_process` lib module.

PR-URL: #38222
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
richardlau pushed a commit that referenced this pull request Jul 19, 2021
Added JSDoc typings for the `child_process` lib module.

PR-URL: #38222
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
Added JSDoc typings for the `child_process` lib module.

PR-URL: #38222
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Added JSDoc typings for the `child_process` lib module.

PR-URL: nodejs#38222
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants