Skip to content

src: fix typo in src code guide #37956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: fix typo in src code guide #37956

wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Mar 28, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 28, 2021
@addaleax
Copy link
Member

addaleax commented Mar 28, 2021

👍 to fast-track, by the way (if we're still doing that)

@addaleax addaleax added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels Mar 28, 2021
RaisinTen pushed a commit that referenced this pull request Mar 28, 2021
@tniessen @RaisinTen
src: fix typo in src code guide
ed6e8f6 
PR-URL: #37956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@RaisinTen
Copy link
Member

RaisinTen commented Mar 28, 2021

Landed in ed6e8f6

@RaisinTen RaisinTen closed this Mar 28, 2021
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
@tniessen @ruyadorno
src: fix typo in src code guide
3e96f43 
PR-URL: #37956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
@tniessen @ruyadorno
src: fix typo in src code guide
bd87e19 
PR-URL: #37956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@tniessen @targos
src: fix typo in src code guide
d0cb129 
PR-URL: #37956
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@tniessen tniessen deleted the src-readme-typo branch October 7, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@Vonaras4 Vonaras4 Vonaras4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen @addaleax @RaisinTen @targos @richardlau @Lxxyx @Vonaras4 @nodejs-github-bot