Skip to content

doc: fix AbortError catch error example in timers.md #37738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2021
Merged

doc: fix AbortError catch error example in timers.md #37738

merged 1 commit into from
Mar 19, 2021

Conversation

@dbachko
Copy link
Contributor

@dbachko dbachko commented Mar 13, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Mar 13, 2021
@aduh95 aduh95 requested a review from jasnell March 13, 2021 10:22
@benjamingr
Copy link
Member

benjamingr commented Mar 13, 2021

👍 to fast track

@Lxxyx Lxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 18, 2021
@dbachko @aduh95
doc: fix AbortError example for timers
31d83f5 
PR-URL: nodejs#37738
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@aduh95 aduh95 force-pushed the fix/abort-error-example branch from 9bf6d06 to 31d83f5 Compare March 19, 2021 11:20
@aduh95
Copy link
Contributor

aduh95 commented Mar 19, 2021

Landed in 31d83f5

@aduh95 aduh95 merged commit 31d83f5 into nodejs:master Mar 19, 2021
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@dbachko @ruyadorno
doc: fix AbortError example for timers
c4183bb 
PR-URL: #37738
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@dbachko @targos
doc: fix AbortError example for timers
a27534e 
PR-URL: #37738
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@jasnell jasnell Awaiting requested review from jasnell

+1 more reviewer

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@dbachko @benjamingr @aduh95 @lpinca @cjihrig @Lxxyx @marsonya @RaisinTen @PoojaDurgad @nodejs-github-bot