tls: refactor to avoid unsafe array iteration #37655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
RaisinTen
approved these changes
Mar 8, 2021
Lxxyx
approved these changes
Mar 8, 2021
Collaborator
Lxxyx
added
author ready
Trott
approved these changes
Mar 10, 2021
Collaborator
Collaborator
PR-URL: nodejs#37655 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
aduh95
force-pushed
the
tls-array-iteration
branch
from
fe358f9 to
c2a792f
Compare
Contributor
Author
|
Landed in c2a792f |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37655 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37655 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.