Skip to content

src: fix typo in test_node_crypto.cc #37469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: fix typo in test_node_crypto.cc #37469

wants to merge 1 commit into from

Conversation

@eltociear
Copy link
Contributor

@eltociear eltociear commented Feb 22, 2021

settting -> setting

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 22, 2021
juanarbol
juanarbol approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 23, 2021
@jasnell
Copy link
Member

jasnell commented Feb 23, 2021

Please 👍🏻 to fast-track

RaisinTen pushed a commit that referenced this pull request Feb 24, 2021
@eltociear @RaisinTen
test: fix typo in test_node_crypto.cc
2d52dc3 
settting -> setting

PR-URL: #37469
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@RaisinTen
Copy link
Member

RaisinTen commented Feb 24, 2021

Landed in 2d52dc3

@RaisinTen RaisinTen closed this Feb 24, 2021
targos pushed a commit that referenced this pull request Feb 28, 2021
@eltociear @targos
test: fix typo in test_node_crypto.cc
ce7fbbf 
settting -> setting

PR-URL: #37469
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos targos mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@marsonya marsonya marsonya approved these changes

@juanarbol juanarbol juanarbol approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@PoojaDurgad PoojaDurgad PoojaDurgad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.