test: remove outdated V8 flag #37151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag is going to be removed upstream in V8 9.0. Refs: v8/v8@0a480c3
cjihrig
approved these changes
Jan 30, 2021
jasnell
approved these changes
Jan 31, 2021
benjamingr
approved these changes
Jan 31, 2021
Collaborator
richardlau
approved these changes
Jan 31, 2021
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
I assume we want to keep the flag on the older V8 versions and don’t want this backported?
Collaborator
gengjiawen
approved these changes
Jan 31, 2021
RaisinTen
approved these changes
Jan 31, 2021
Trott
approved these changes
Jan 31, 2021
gireeshpunathil
approved these changes
Feb 1, 2021
targos
added a commit
that referenced
this pull request
Feb 2, 2021
The flag is going to be removed upstream in V8 9.0. Refs: v8/v8@0a480c3 PR-URL: #37151 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Member
Author
|
Landed in 501ae0e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is going to be removed upstream in V8 9.0.
Refs: v8/v8@0a480c3