Skip to content

fix typo #36719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix typo #36719

wants to merge 1 commit into from

Conversation

@pmj642
Copy link
Contributor

@pmj642 pmj642 commented Jan 1, 2021

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Jan 1, 2021
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 1, 2021
@yashLadha
Copy link
Contributor

yashLadha commented Jan 1, 2021

Commit message can be improved though 😅 . Like using a substem http2: fix a typo error in comment

@yashLadha
Copy link
Contributor

yashLadha commented Jan 1, 2021

@pmj642 You can amend and then force push it.

@pmj642
Copy link
Contributor Author

pmj642 commented Jan 1, 2021

@yashLadha I actually found one more typo in the same file, so I was thinking of adding it to the same PR.

@yashLadha yashLadha added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2021
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
yashLadha pushed a commit that referenced this pull request Jan 4, 2021
@pmj642 @yashLadha
http2: fix typos in core.js
8b8620d 
PR-URL: #36719
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@yashLadha
Copy link
Contributor

yashLadha commented Jan 4, 2021

Landed in 8b8620d

@yashLadha yashLadha closed this Jan 4, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@pmj642 @danielleadams
http2: fix typos in core.js
e85fbb7 
PR-URL: #36719
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@pmj642 @targos
http2: fix typos in core.js
16a1650 
PR-URL: #36719
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Yash Ladha <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

+2 more reviewers

@watilde watilde watilde approved these changes

@yashLadha yashLadha yashLadha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pmj642 @yashLadha @jasnell @Trott @watilde @aduh95 @nodejs-github-bot