lib: refactor to use validateAbortSignal #36604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v12.x
quic
benjamingr
approved these changes
Dec 22, 2020
Trott
approved these changes
Dec 22, 2020
github-actions
bot
removed
the
request-ci
Collaborator
juanarbol
approved these changes
Dec 22, 2020
lpinca
reviewed
Dec 22, 2020
richardlau
approved these changes
Dec 22, 2020
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
aduh95
added
the
author ready
PR-URL: nodejs#36604 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Trott
force-pushed
the
refactor-to-use-validate-abort-signal
branch
from
e402095 to
4905501
Compare
Member
|
Landed in 4905501 |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36604 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 24, 2021
PR-URL: nodejs#36604 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 26, 2021
PR-URL: nodejs#36604 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#36604 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2021
PR-URL: #36604 Backport-PR-URL: #38386 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos
added
backported-to-v14.x
and removed
author ready
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes