tools: upgrade to @babel/eslint-parser 7.12.1 #36321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Dec 1, 2020
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
Great, I was recently trying to use Private Fields instead of Symbol, but found that ESLint doesn't support Private Fields. this PR solves the problem. |
Member
|
Rubber stamp LGTM |
jasnell
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36321 Fixes: https://github.com/ensure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 5f1bf80 |
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36321 Fixes: https://github.com/ensure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
PR-URL: nodejs#36321 Fixes: https://github.com/ensure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36321 Fixes: https://github.com/ensure Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-eslint is now @babel/eslint-parser and has moved into the Babel monorepo.
CHANGELOG:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes