doc: add history entry for breaking destroy() change #35326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Sep 24, 2020
Trott
approved these changes
Sep 26, 2020
Trott
reviewed
Sep 26, 2020
| changes: | ||
| - version: v14.0.0 | ||
| pr-url: https://github.com/nodejs/node/pull/29197 | ||
| description: Work as noop when called on an already `destroyed` stream. |
Member
There was a problem hiding this comment.
Optional suggestion for here and below:
Suggested change
| description: Work as noop when called on an already `destroyed` stream. | |
| description: Work as noop when called on an already-destroyed stream. |
Trott
pushed a commit
that referenced
this pull request
Sep 27, 2020
Refs: #29197 (comment) PR-URL: #35326 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
|
Landed in 7fcbeb4. |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 29, 2020
Refs: #29197 (comment) PR-URL: #35326 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Refs: nodejs#29197 (comment) PR-URL: nodejs#35326 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29197 (comment).
Checklist