Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions test/parallel/test-fs-write-reuse-callback.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// Flags: --expose-gc
'use strict';
const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const path = require('path');

// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/814:
// Make sure that Buffers passed to fs.write() are not garbage-collected
// even when the callback is being reused.

const fs = require('fs');

tmpdir.refresh();
const filename = path.join(tmpdir.path, 'test.txt');
const fd = fs.openSync(filename, 'w');

const size = 16 * 1024;
const writes = 1000;
let done = 0;

const ondone = common.mustCall((err) => {
assert.ifError(err);
if (++done < writes) {
if (done % 25 === 0) global.gc();
setImmediate(write);
} else {
assert.strictEqual(
fs.readFileSync(filename, 'utf8'),
'x'.repeat(writes * size));
}
}, writes);

write();
function write() {
const buf = Buffer.alloc(size, 'x');
fs.write(fd, buf, 0, buf.size, -1, ondone);
}
90 changes: 0 additions & 90 deletions test/pummel/test-regress-GH-814.js

This file was deleted.

105 changes: 0 additions & 105 deletions test/pummel/test-regress-GH-814_2.js

This file was deleted.