Skip to content

Conversation

@legendecas
Copy link
Member

Fixes: #30516 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 6, 2020
@legendecas legendecas mentioned this pull request Jun 6, 2020
4 tasks
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 6, 2020
@targos
Copy link
Member

targos commented Jun 6, 2020

Simple bug fix in a test... Fast-track?

@nodejs-github-bot
Copy link
Collaborator

@legendecas
Copy link
Member Author

Landed in 5590ee0

legendecas added a commit that referenced this pull request Jun 9, 2020
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@legendecas legendecas closed this Jun 9, 2020
@legendecas legendecas deleted the test-trace-exit-regex branch June 9, 2020 06:55
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #33769
Fixes: #30516
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants