Skip to content

Update async_hooks.md #32382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update async_hooks.md #32382

wants to merge 1 commit into from

Conversation

@Doc999tor
Copy link
Contributor

@Doc999tor Doc999tor commented Mar 20, 2020

Typo runAndReturn -> runSyncAndReturn

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@Doc999tor
Update async_hooks.md
3232201 
Typo `runAndReturn` -> `runSyncAndReturn`
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Mar 20, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 20, 2020
MylesBorins pushed a commit that referenced this pull request Mar 26, 2020
@Doc999tor @MylesBorins
doc: update async_hooks.md
afb5639 
Typo `runAndReturn` -> `runSyncAndReturn`

PR-URL: #32382
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 26, 2020

Landed in afb5639

MylesBorins pushed a commit that referenced this pull request Mar 26, 2020
@Doc999tor @MylesBorins
doc: update async_hooks.md
3e002c3 
Typo `runAndReturn` -> `runSyncAndReturn`

PR-URL: #32382
Reviewed-By: Vladimir de Turckheim <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 26, 2020
Merged
@Doc999tor Doc999tor deleted the patch-1 branch March 27, 2020 08:22
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@Flarna Flarna Flarna approved these changes

+1 more reviewer

@vdeturckheim vdeturckheim vdeturckheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.