test: replace instances of common.PORT in pummel tests with port "0" #31897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundibundi
approved these changes
Feb 21, 2020
Pummel tests don't run in our regular CI, but it's all green in the special CI above. |
Trott
added
the
author ready
Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: nodejs#31897 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
|
Landed in 97c8abe |
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: #31897 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: #31897 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: #31897 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Use port "0" for an OS-provided open port instead of common.PORT. PR-URL: #31897 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes