src: use hex not decimal in IsArrayIndex

[codebytere]

In Electron, clang enforces -Wxor-used-as-pow, so the previous line would cause the following error:

../../third_party/electron_node/src/module_wrap.cc:926:34: error: result of '2 ^ 32' is 34; did you mean '1LL << 32'? [-Werror,-Wxor-used-as-pow]
  return n_dbl > 0 && n_dbl < (2 ^ 32) - 1;
                               ~~^~~~

The simplest solution i see is to just use hex to clarify intent for the compiler, and so this PR does so.

cc @guybedford

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[guybedford]

@codebytere thanks for the PR, and apologies for the compiler issue!

This is actually a completely daft bug, which I included a fix for, rolled into the PR at https://github.com/nodejs/node/pull/31625/files#diff-4a5950be44f56dfca2e7fa3c4e1fc0e4R966, although that PR with the current approval will take another 5 days to land unless we get another approval there.

If that is the case, and you need this sooner, it may well be better to just port that fix here.

[addaleax]

Yeah, I think the compiler is correct to warn here, and we should use its suggestion rather than just make the warning go away :)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29094/

[addaleax]

Since this would be ready to land now, I’ll make it explicit that the previous code was buggy and we should not remove the warning about the bug (and rather fix it)

[addaleax]

Thanks!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29098/

[codebytere]

Landed in 3a22549