src: remove dead code in InternalMakeCallback #31622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded condition as the first line in function already ensures that recv can't be empty.
nodejs-github-bot
added
the
c++
legendecas
approved these changes
Feb 3, 2020
tniessen
approved these changes
Feb 3, 2020
jasnell
approved these changes
Feb 3, 2020
addaleax
approved these changes
Feb 3, 2020
devnexen
approved these changes
Feb 3, 2020
cjihrig
approved these changes
Feb 3, 2020
lpinca
approved these changes
Feb 3, 2020
yhwang
approved these changes
Feb 5, 2020
BridgeAR
approved these changes
Feb 6, 2020
addaleax
added
the
author ready
Collaborator
Collaborator
Collaborator
Collaborator
addaleax
pushed a commit
that referenced
this pull request
Feb 8, 2020
Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: #31622 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yihong Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
|
Landed in 7a63d76 |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: #31622 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yihong Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: #31622 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yihong Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: #31622 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yihong Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: #31622 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yihong Wang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded condition as the first line in function already ensures that recv can't be empty.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes