Skip to content

worker: removed redundant closing of child port. #31555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

worker: removed redundant closing of child port. #31555

wants to merge 1 commit into from

Conversation

@aaccttrr
Copy link
Contributor

@aaccttrr aaccttrr commented Jan 28, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Jan 28, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/28738/

@richardlau
Copy link
Member

richardlau commented Jan 28, 2020

For my own benefit why is this redundant? Is the child port closed elsewhere?

@addaleax
Copy link
Member

addaleax commented Jan 29, 2020

@richardlau It’s closed as part of the Environment’s RunCleanup() call that also closes all other handles

@Trott
Copy link
Member

Trott commented Jan 31, 2020

Landed in 9225939

@Trott Trott closed this Jan 31, 2020
Trott pushed a commit that referenced this pull request Jan 31, 2020
@aaccttrr @Trott
worker: remove redundant closing of child port
9225939 
PR-URL: #31555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@aaccttrr @codebytere
worker: remove redundant closing of child port
6fdef45 
PR-URL: #31555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@aaccttrr @codebytere
worker: remove redundant closing of child port
f640a54 
PR-URL: #31555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@aaccttrr @codebytere
worker: remove redundant closing of child port
14d6d0d 
PR-URL: #31555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@aaccttrr @codebytere
worker: remove redundant closing of child port
5500521 
PR-URL: #31555
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aaccttrr @nodejs-github-bot @richardlau @addaleax @Trott @jasnell @cjihrig @devnexen