Skip to content

build: fix macos runner type #31327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: fix macos runner type #31327

wants to merge 1 commit into from

Conversation

@himself65
Copy link
Member

@himself65 himself65 commented Jan 12, 2020

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 12, 2020
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2020
@Trott
Copy link
Member

Trott commented Jan 14, 2020

Landed in 9da241b

@Trott Trott closed this Jan 14, 2020
Trott pushed a commit that referenced this pull request Jan 14, 2020
@himself65 @Trott
build: fix macos runner type in GitHub Action
9da241b 
PR-URL: #31327
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
cjihrig added a commit to nodejs/uvwasi that referenced this pull request Jan 16, 2020
@cjihrig
ci: fix macos casing in CI.yml
0be109b 
Refs: nodejs/node#31327
@cjihrig cjihrig mentioned this pull request Jan 16, 2020
Merged
cjihrig added a commit to nodejs/uvwasi that referenced this pull request Jan 16, 2020
@cjihrig
ci: fix macos casing in CI.yml
a3c23fa 
Refs: nodejs/node#31327
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@himself65 @MylesBorins
build: fix macos runner type in GitHub Action
b2180d9 
PR-URL: #31327
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@himself65 @codebytere
build: fix macos runner type in GitHub Action
2863bef 
PR-URL: #31327
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 2, 2020
@himself65 @MylesBorins
build: fix macos runner type in GitHub Action
bf04e09 
PR-URL: nodejs#31327
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 2, 2020
@himself65 @MylesBorins
build: fix macos runner type in GitHub Action
ad12c82 
Backport-PR-URL: #32608
PR-URL: #31327
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Apr 3, 2020
Merged
@himself65 himself65 deleted the ci branch April 4, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@JungMinu JungMinu JungMinu approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@antsmartian antsmartian antsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@himself65 @Trott @antsmartian @lpinca @gengjiawen @JungMinu @richardlau @BridgeAR @nodejs-github-bot