Skip to content

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Hello,
For this PR I have added Int32Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Int32Array 
      message: "Use `const { Int32Array } = primordials;` instead of the global."

And just add Int32Array .

const {
  // [...]
  Int32Array,
} = primordials;

I hope this new PR will help you :x

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jan 6, 2020
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@BridgeAR
Copy link
Member

This needs a rebase.

@antsmartian
Copy link
Contributor

@Sebastien-Ahkrin Ping. This needs a rebase.

@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the Int32ArrayPrimordials branch from 60efb2f to 780661e Compare May 29, 2020 09:57
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:19
Co-authored-by: Michaël Zasso <[email protected]>
@targos
Copy link
Member

targos commented Sep 28, 2020

Superseded by #35397

@targos targos closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants