-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
lib: add Int32Array primordials #31206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Sebastien-Ahkrin
wants to merge
2
commits into
nodejs:master
from
Sebastien-Ahkrin:Int32ArrayPrimordials
Closed
lib: add Int32Array primordials #31206
Sebastien-Ahkrin
wants to merge
2
commits into
nodejs:master
from
Sebastien-Ahkrin:Int32ArrayPrimordials
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Refs: #30697 |
targos
approved these changes
Jan 6, 2020
cjihrig
approved these changes
Jan 6, 2020
trivikr
approved these changes
Jan 6, 2020
jasnell
approved these changes
Jan 6, 2020
BridgeAR
approved these changes
Jan 6, 2020
patilharshal16
approved these changes
Jan 7, 2020
Trott
approved these changes
Jan 7, 2020
Member
|
This needs a rebase. |
Contributor
|
@Sebastien-Ahkrin Ping. This needs a rebase. |
60efb2f to
780661e
Compare
8ae28ff to
2935f72
Compare
targos
reviewed
Jun 2, 2020
Co-authored-by: Michaël Zasso <[email protected]>
Member
|
Superseded by #35397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
For this PR I have added Int32Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".
And just add Int32Array .
I hope this new PR will help you :x