Skip to content

Conversation

Sebastien-Ahkrin
Copy link
Contributor

@Sebastien-Ahkrin Sebastien-Ahkrin commented Jan 6, 2020

Hello,
For this PR I have added Float64Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Float64Array 
      message: "Use `const { Float64Array } = primordials;` instead of the global."

And just add Float64Array.

const {
  // [...]
  Float64Array,
} = primordials;

I hope this new PR will help you :x

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 6, 2020
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@BridgeAR
Copy link
Member

This needs a rebase.

@Sebastien-Ahkrin Sebastien-Ahkrin force-pushed the Float64ArrayPrimordials branch from 8ed9483 to 21318ea Compare May 29, 2020 09:47
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:19
@targos
Copy link
Member

targos commented Sep 28, 2020

Superseded by #35397

@targos targos closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants