Skip to content

test: refactor test-accessor-properties #29943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: refactor test-accessor-properties #29943

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb7d325
test: refactor test-accessor-properties
himself65 Oct 13, 2019
bb27a47
Update test/parallel/test-accessor-properties.js
himself65 Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions test/parallel/test-accessor-properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,6 @@ const UDP = internalBinding('udp_wrap').UDP;

{
// Should throw instead of raise assertions
assert.throws(() => {
TTY.prototype.bytesRead;
}, TypeError);

assert.throws(() => {
TTY.prototype.fd;
}, TypeError);

assert.throws(() => {
TTY.prototype._externalStream;
}, TypeError);

assert.throws(() => {
UDP.prototype.fd;
}, TypeError);
Expand All @@ -36,6 +24,11 @@ const UDP = internalBinding('udp_wrap').UDP;
const properties = ['bytesRead', 'fd', '_externalStream'];

properties.forEach((property) => {
// Should throw instead of raise assertions
assert.throws(() => {
TTY.prototype[property];
}, TypeError, `TypeError on: TTY.prototype.${property}`);

// Should not throw for Object.getOwnPropertyDescriptor
assert.strictEqual(
typeof Object.getOwnPropertyDescriptor(StreamWrapProto, property),
Expand Down