Skip to content

Conversation

gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Sep 18, 2019

PR-URL: #29461

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

PR-URL: nodejs#29461
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. v12.x labels Sep 18, 2019
@gabrielschulhof
Copy link
Contributor Author

Note: #29401 ought to be backported first. It should apply cleanly to v12.x.

@richardlau richardlau mentioned this pull request Sep 24, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member

Landed on staging: 325de43

@BridgeAR BridgeAR closed this Sep 25, 2019
@gabrielschulhof gabrielschulhof deleted the backport-29461-to-12.x branch March 13, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants