Skip to content

test: use fs rimraf to refresh tmpdir #29235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

test: use fs rimraf to refresh tmpdir #29235

wants to merge 3 commits into from

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 20, 2019

Ignore the first two commits, which are just #29168.

Commit: test: use fs rimraf to refresh tmpdir

If rimraf lands in core, we should use it to refresh the tmpdir in our test suite. We should be able to remove even more of this code (like spawning a child process), but I figured this was a good starting point.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

cjihrig added 3 commits August 20, 2019 17:05
@cjihrig
fs: add recursive option to rmdir()
9f35348 
This commit adds a recursive option to fs.rmdir(),
fs.rmdirSync(), and fs.promises.rmdir(). The implementation
is a port of the npm module rimraf.
@cjihrig
meta: include rimraf in LICENSE file
78ab512
@cjihrig
test: use fs rimraf to refresh tmpdir
41ad336 
Now that the functionality is built into core, use it to
refresh the test suite's tmpdir.
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 20, 2019
@gengjiawen
Copy link
Member

gengjiawen commented Aug 23, 2019

https://travis-ci.com/nodejs/node/jobs/226852561#L270

=== release test-fs-readdir-ucs2 ===
Path: parallel/test-fs-readdir-ucs2
--- stderr ---
Can't clean tmpdir: /home/travis/build/nodejs/node/test/.tmp.602
Files blocking: [ '=�\u0004�' ]
/home/travis/build/nodejs/node/test/common/tmpdir.js:88
    throw e;
    ^
Error: Unable to rimraf /home/travis/build/nodejs/node/test/.tmp.602
    at rimrafSync (/home/travis/build/nodejs/node/test/common/tmpdir.js:42:11)
    at process.onexit (/home/travis/build/nodejs/node/test/common/tmpdir.js:73:5)
    at process.emit (events.js:214:15)
Command: out/Release/node /home/travis/build/nodejs/node/test/parallel/test-fs-readdir-ucs2.js

@richardlau richardlau mentioned this pull request Oct 22, 2019
Closed
3 tasks
@cjihrig cjihrig closed this Oct 23, 2019
@cjihrig cjihrig mentioned this pull request Nov 20, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig @gengjiawen @Trott @targos @nodejs-github-bot