Skip to content

lib: enforce the use of Object from primordials #27146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

lib: enforce the use of Object from primordials #27146

wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

@targos targos commented Apr 9, 2019

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3206

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 9, 2019
cjihrig
cjihrig approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22290/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22292/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/22293/

@joyeecheung joyeecheung mentioned this pull request Apr 10, 2019
Closed
2 tasks
@danbev
Copy link
Contributor

danbev commented Apr 12, 2019

Landed in 908292c.

@danbev danbev closed this Apr 12, 2019
danbev pushed a commit that referenced this pull request Apr 12, 2019
@targos @danbev
lib: enforce the use of Object from primordials
908292c 
PR-URL: #27146
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@trptcolin
Copy link

trptcolin commented May 18, 2019

I just wanted to say thank you for this fix! 🙇 ❤️ Much appreciated.

Bumped up against this issue on an older node version due to a userspace monkey-patch (of Object.defineProperty in an ES5 shim from one of our dependencies, and I'm glad to see someone's already done the hard work of solving the underlying issue. Thanks!

@targos targos deleted the primordial-object branch May 18, 2019 20:47
@mcollina mcollina mentioned this pull request Jul 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+1 more reviewer

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.