Skip to content

node: add missing environment variables to --help and man page #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

node: add missing environment variables to --help and man page #2690

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fea99f
node: add NODE_REPL_HISTORY to --help, fix case
silverwind Sep 4, 2015
410559e
add vars to node.1 and reword help description
silverwind Sep 4, 2015
9947aa0
fix typo, small rewording
silverwind Sep 4, 2015
5d09560
parens
silverwind Sep 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion doc/node.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,15 @@ and servers.

.IP NODE_PATH
\':\'\-separated list of directories prefixed to the module search path.

.IP NODE_DISABLE_COLORS
If set to 1 then colors will not be used in the REPL.
.IP NODE_ICU_DATA
Data path for ICU (Intl object) data. Will extend linked-in data when compiled
with small-icu support.
.IP NODE_REPL_HISTORY
Path to the file used to store the persistent REPL history. The default path
is ~/.node_repl_history, which is overridden by this variable. Setting the
value to an empty string "" disables persistent REPL history.
Copy link
Contributor

@Fishrock123 Fishrock123 Sep 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

("") ?

Copy link
Contributor Author

@silverwind silverwind Sep 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, might be clearer.


.SH V8 OPTIONS

Expand Down
7 changes: 4 additions & 3 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3064,7 +3064,7 @@ static void PrintHelp() {
" --icu-data-dir=dir set ICU data load path to dir\n"
" (overrides NODE_ICU_DATA)\n"
#if !defined(NODE_HAVE_SMALL_ICU)
" Note: linked-in ICU data is\n"
" note: linked-in ICU data is\n"
" present.\n"
#endif
#endif
Expand All @@ -3076,13 +3076,14 @@ static void PrintHelp() {
"NODE_PATH ':'-separated list of directories\n"
#endif
" prefixed to the module search path.\n"
"NODE_DISABLE_COLORS Set to 1 to disable colors in the REPL\n"
"NODE_DISABLE_COLORS set to 1 to disable colors in the REPL\n"
#if defined(NODE_HAVE_I18N_SUPPORT)
"NODE_ICU_DATA Data path for ICU (Intl object) data\n"
"NODE_ICU_DATA data path for ICU (Intl object) data\n"
#if !defined(NODE_HAVE_SMALL_ICU)
" (will extend linked-in data)\n"
#endif
#endif
"NODE_REPL_HISTORY path to the persistent REPL history file\n"
"\n"
"Documentation can be found at https://nodejs.org/\n");
}
Expand Down