Skip to content

buffer: throw if Buffer.from() receives a function #26743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

buffer: throw if Buffer.from() receives a function #26743

wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 18, 2019 •
edited
Loading

Fixes: #26743

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 18, 2019

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2966/pipeline

@nodejs-github-bot nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Mar 18, 2019
@cjihrig cjihrig mentioned this pull request Mar 18, 2019
Closed
@cjihrig cjihrig closed this Mar 18, 2019
@Fishrock123
Copy link
Contributor

Fishrock123 commented Mar 18, 2019

@cjihrig Did you mean to close this?

@BridgeAR BridgeAR mentioned this pull request Mar 20, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devsnek devsnek devsnek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjihrig @nodejs-github-bot @Fishrock123 @devsnek