Skip to content

tools: update ESLint to 5.14.0 #26142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2019
Merged

tools: update ESLint to 5.14.0 #26142

merged 1 commit into from
Feb 18, 2019

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 15, 2019

Update ESLint to 5.14.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 15, 2019

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2629/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 15, 2019
Trott
Trott approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 15, 2019
@cjihrig
tools: update ESLint to 5.14.0
77b39c2 
Update ESLint to 5.14.0

PR-URL: nodejs#26142
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 18, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20847/

@cjihrig cjihrig merged commit 77b39c2 into nodejs:master Feb 18, 2019
@cjihrig cjihrig deleted the eslint branch February 18, 2019 02:58
addaleax pushed a commit that referenced this pull request Feb 18, 2019
@cjihrig @addaleax
tools: update ESLint to 5.14.0
19fadd8 
Update ESLint to 5.14.0

PR-URL: #26142
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig @rvagg
tools: update ESLint to 5.14.0
28d6074 
Update ESLint to 5.14.0

PR-URL: #26142
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

+1 more reviewer

@geek geek geek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjihrig @nodejs-github-bot @geek @Trott