Skip to content

build: lint .eslintrc.js file #19122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

build: lint .eslintrc.js file #19122

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Mar 4, 2018

Update default files to be linted with ESLint to include .eslintrc.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@Trott
build: lint .eslintrc.js file
784229c 
Update default files to be linted with ESLint to include .eslintrc.js.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Mar 4, 2018
@Trott
Copy link
Member Author

Trott commented Mar 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13476/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 4, 2018
@apapirovski
Copy link
Contributor

apapirovski commented Mar 6, 2018

Landed in f05eaa4

@apapirovski apapirovski closed this Mar 6, 2018
apapirovski pushed a commit that referenced this pull request Mar 6, 2018
@Trott @apapirovski
build: lint .eslintrc.js file
f05eaa4 
Update default files to be linted with ESLint to include .eslintrc.js.

PR-URL: #19122
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 6, 2018

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Trott @MayaLekova
build: lint .eslintrc.js file
48de87d 
Update default files to be linted with ESLint to include .eslintrc.js.

PR-URL: nodejs#19122
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the lint-it-all branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+3 more reviewers

@XadillaX XadillaX XadillaX approved these changes

@devsnek devsnek devsnek approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.