Skip to content

test: fix unreliable async-hooks/test-signalwrap #17827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: fix unreliable async-hooks/test-signalwrap #17827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/async-hooks/test-signalwrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
'use strict';
const common = require('../common');

if (common.isWindows) return common.skip('no signals in Windows');
if (common.isWindows)
common.skip('no signals in Windows');

const assert = require('assert');
const initHooks = require('./init-hooks');
Expand All @@ -11,6 +12,10 @@ const exec = require('child_process').exec;
const hooks = initHooks();

hooks.enable();

// Keep the event loop open so process doesn't exit before receiving signals.
const interval = setInterval(() => {}, 9999);

process.on('SIGUSR2', common.mustCall(onsigusr2, 2));

const as = hooks.activitiesOfTypes('SIGNALWRAP');
Expand Down Expand Up @@ -66,6 +71,7 @@ function onsigusr2() {
}

function onsigusr2Again() {
clearInterval(interval);
setImmediate(() => {
checkInvocations(
signal1, { init: 1, before: 2, after: 2, destroy: 1 },
Expand Down