Skip to content

test: use common.throwOnUnhandledRejection #17231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: use common.throwOnUnhandledRejection #17231

wants to merge 1 commit into from

Conversation

jimliu7434
Copy link
Contributor

@jimliu7434 jimliu7434 commented Nov 22, 2017 •
edited
Loading

Add common.crashOnUnhandledRejection to test/parallel/test-async-wrap-promise-after-enabled.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@jimliu7434
test: use common.throwOnUnhandledRejection
af1b89e 
Add common.crashOnUnhandledRejection to test/parallel/test-async-wrap-promise-after-enabled.js
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11618/

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
jasnell pushed a commit to jasnell/node that referenced this pull request Nov 22, 2017
@jimliu7434 @jasnell
test: use common.crashOnUnhandledRejection
685abcd 
Add common.crashOnUnhandledRejection to
test-async-wrap-promise-after-enabled.js

PR-URL: nodejs#17231
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Landed in 685abcd! Thank you and congrats on your PR to core!

@jasnell jasnell closed this Nov 22, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@jimliu7434 @MylesBorins
test: use common.crashOnUnhandledRejection
142668d 
Add common.crashOnUnhandledRejection to
test-async-wrap-promise-after-enabled.js

PR-URL: #17231
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@jimliu7434 @MylesBorins
test: use common.crashOnUnhandledRejection
dc4aa89 
Add common.crashOnUnhandledRejection to
test-async-wrap-promise-after-enabled.js

PR-URL: #17231
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@jimliu7434 @gibfahn
test: use common.crashOnUnhandledRejection
3d86f32 
Add common.crashOnUnhandledRejection to
test-async-wrap-promise-after-enabled.js

PR-URL: #17231
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@jimliu7434 @gibfahn
test: use common.crashOnUnhandledRejection
0e4a681 
Add common.crashOnUnhandledRejection to
test-async-wrap-promise-after-enabled.js

PR-URL: #17231
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jimliu7434 @gireeshpunathil @jasnell @MylesBorins @cjihrig @mscdex @gibfahn @nodejs-github-bot