n-api: use module name macro #16185
Closed
n-api: use module name macro #16185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to use module name macro
nodejs-github-bot
added
dont-land-on-v4.x
node-api
gabrielschulhof
approved these changes
Oct 13, 2017
Contributor
gabrielschulhof
left a comment
gabrielschulhof
left a comment
There was a problem hiding this comment.
@mhdawson there are a few more:
$ git grep -nEH '^(NAPI|NODE)_MODULE' -- test | \
grep -vE 'BUILTIN|NODE_GYP_MODULE_NAME|INTERNAL' | \
awk -F ':' '{ print $1; }' | \
sort -u
test/addons/callback-scope/binding.cc
test/addons/dlopen-ping-pong/binding.cc
test/addons-napi/test_warning/test_warning2.c
test/addons-napi/test_warning/test_warning.c
test/addons/node-module-version/binding.cc
test/addons/openssl-binding/binding.cc
test/addons/zlib-binding/binding.cc
test/gc/binding.ccMight as well catch 'em all, eh?
Member
Author
|
sure, I guess I used the wrong search. Updating now. |
Member
Author
|
Ah I see they are not in the n-api set thats why I did not see them. Anyway fixing them up |
Member
Author
|
@gabrielschulhof pushed commit to update the rest of them |
jasnell
approved these changes
Oct 13, 2017
gabrielschulhof
approved these changes
Oct 14, 2017
Member
cjihrig
approved these changes
Oct 15, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 15, 2017
Update tests to use module name macro PR-URL: #16185 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
|
Landed in 6bc82da |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Update tests to use module name macro PR-URL: #16185 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
Update tests to use module name macro PR-URL: nodejs/node#16185 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 16, 2018
Update tests to use module name macro PR-URL: nodejs#16185 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Update tests to use module name macro Backport-PR-URL: #19447 PR-URL: #16185 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests to use module name macro
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api, test