Skip to content

Conversation

@kfarnung
Copy link
Contributor

@kfarnung kfarnung commented Oct 9, 2017

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 9, 2017
@kfarnung
Copy link
Contributor Author

kfarnung commented Oct 9, 2017

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 9, 2017
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 9, 2017
PR-URL: nodejs#16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@kfarnung
Copy link
Contributor Author

kfarnung commented Oct 9, 2017

Landed in f8dd1ac

@kfarnung kfarnung closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
PR-URL: #16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
PR-URL: #16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants