Revert "test: port test for make_callback to n-api" #12475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70b51c8.
nodejs-github-bot
added
node-api
Member
Author
cjihrig
approved these changes
Apr 17, 2017
jasnell
added a commit
that referenced
this pull request
Apr 17, 2017
This reverts commit 70b51c8. PR-URL: #12475 Reviewed-By: Colin Ihrig <[email protected]>
1 task
Member
Author
3 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
This reverts commit 70b51c8. PR-URL: nodejs#12475 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
This reverts commit 70b51c8. Backport-PR-URL: #19447 PR-URL: #12475 Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sigh... I think the jet lag is setting in and I need to call it quits for the afternoon. 70b51c8 is broken on Windows.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test