linkedlist: remove public module #12113

mscdex · 2017-03-29T07:45:35Z

This removes the public _linklist node core module which has been (runtime) deprecated since v5.0.0.

CI: https://ci.nodejs.org/job/node-test-pull-request/7086/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/677/

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

linkedlist

mscdex · 2017-03-29T07:50:47Z

/cc @nodejs/ctc

Trott · 2017-03-29T13:38:29Z

Since _linklist will not exist anymore with this change, can you remove it from the list of restricted modules in .eslintrc.yaml?

  no-restricted-modules: [2, sys, _linklist]

to:

  no-restricted-modules: [2, sys]

mscdex · 2017-03-29T15:34:43Z

@Trott Done.

Trott · 2017-03-29T19:29:17Z

Should we do a check to see how often including _linklist happens in the npm registry?

jasnell · 2017-03-29T20:08:30Z

Definitely. Tho a quick github search shows only hits for node.js core forks. I'm sure some uses still exist out there. Paging @ChALkeR :-)

evanlucas

LGTM provided there are no uses found by @ChALkeR in the ecosystem

jasnell · 2017-04-04T12:56:20Z

Ping @ChALkeR ...

jasnell · 2017-04-04T17:03:01Z

A code search on github showed no significant hits (a couple of old projects that haven't been updated in a number of years). I'm going to go ahead and land given the approvals.

PR-URL: #12113 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

jasnell · 2017-04-04T17:15:23Z

Landed in 84a2339

ChALkeR · 2017-05-04T12:30:28Z

Yes, sorry for missing this one. The old usage stats from 1½ years ago consisted of 17 modules: #3078 (comment).

More up to date data (2017-02):

2418    babybird-0.0.1.tgz/benchmark/lib/timers-ctx.js:23:var L = require('_linklist');
1929    commonjs-everywhere-0.9.7.tgz/node/lib/timers.js:23:var L = require('_linklist');
165     micropromise-0.4.10.tgz/promise-bench/benchmark/lib/timers-ctx.js:23:var L = require('_linklist');
67      candle-0.4.0.tgz/timers.js:23:var L = require('_linklist');
64      ape-algorithm-0.0.8.tgz/linklist.js:2://var L = require('_linklist');
38      biojs-vis-blast-0.1.5.tgz/node/lib/timers.js:23:var L = require('_linklist');
38      biojs-vis-blast-0.1.5.tgz/node/test/simple/test-timers-linked-list.js:24:var L = require('_linklist');
37      portable-js-0.0.3.tgz/misc/io/timers.js:4:const L = require('_linklist');
37      portable-js-0.0.3.tgz/misc/node/timers.js:25:var L = require('_linklist');
28      jsg-0.0.3.tgz/testdata/node_core_modules/timers.js:23:var L = require('_linklist');
21      chromify-0.0.2.tgz/builtins/timers.js:23:var L = require('_linklist');
19      flush-all-0.1.1.tgz/node-v0.13/lib/timers.js:25:var L = require('_linklist');
19      flush-all-0.1.1.tgz/node-v0.13/test/simple/test-timers-linked-list.js:24:var L = require('_linklist');
19      promise-bench-0.0.2.tgz/benchmark/lib/timers-ctx.js:23:var L = require('_linklist');
18      node-core-lib-0.11.11.tgz/timers.js:23:var L = require('_linklist');
16      node-core-test-simple-0.11.11.tgz/test-timers-linked-list.js:24:var L = require('_linklist');
16      persha-0.2.1.tgz/node-lib/timers.js:23:var L = require('_linklist');
13      pezhu-0.0.0.tgz/Downloads/node-v0.9.11/lib/timers.js:23:var L = require('_linklist');
13      pezhu-0.0.0.tgz/Downloads/node-v0.9.11/test/simple/test-timers-linked-list.js:24:var L = require('_linklist');
9       perf-timers-0.1.0.tgz/bench/settimeout/timers.js:23:var L = require('_linklist');
9       perf-timers-0.1.0.tgz/bench/settimeout/timers2.js:23:var L = require('_linklist');
9       perf-timers-0.1.0.tgz/bench/settimeout/timers3.js:23:var L = require('_linklist');
8       node-natives-0.10.25.tgz/timers.js:23:var L = require('_linklist');
5       perf-time-0.1.0.tgz/bench/settimeout/timers.js:23:var L = require('_linklist');
5       perf-time-0.1.0.tgz/bench/settimeout/timers2.js:23:var L = require('_linklist');
5       perf-time-0.1.0.tgz/bench/settimeout/timers3.js:23:var L = require('_linklist');

There are 18 modules, but those are mostly unused, and they require _linklist from bechmarks and/or copies of Node.js timers.js file.

ChALkeR

Late LGTM ;-). Sorry for not responding earlier.

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](nodejs@4a7233c178)] [nodejs#12892](nodejs#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](nodejs@d2d32ea5a2)] [nodejs#11968](nodejs#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](nodejs@7eb1b4658e)] [nodejs#12141](nodejs#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](nodejs@beca3244e2)] [nodejs#10236](nodejs#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](nodejs@97a77288ce)] [nodejs#12348](nodejs#12348), [[`d75fdd96aa`](nodejs@d75fdd96aa)] [nodejs#10423](nodejs#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](nodejs@627ecee9ed)] [nodejs#10653](nodejs#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](nodejs@f18e08d820)] [nodejs#9744](nodejs#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](nodejs@3c3b36af0f)] [nodejs#12936](nodejs#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](nodejs@60d1aac8d2)] [nodejs#12784](nodejs#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](nodejs@84dabe8373)] [nodejs#12489](nodejs#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](nodejs@7a55e34ef4)] [nodejs#10467](nodejs#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](nodejs@3c2a9361ff)] [nodejs#9683](nodejs#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](nodejs@90403dd1d0)] [nodejs#11567](nodejs#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](nodejs@d3480776c7)] [nodejs#11259](nodejs#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](nodejs@fb71ba4921)] [nodejs#11355](nodejs#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](nodejs@3e6f1032a4)] [nodejs#10805](nodejs#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](nodejs@5de3cf099c)] [nodejs#10116](nodejs#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](nodejs@84a23391f6)] [nodejs#12113](nodejs#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](nodejs@56e881d0b0)] [nodejs#11975](nodejs#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](nodejs@03e89b3ff2)] [nodejs#10116](nodejs#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](nodejs@dd20e68b0f)] [nodejs#12725](nodejs#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](nodejs@3f27f02da0)] [nodejs#11599](nodejs#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (nodejs@ec7cbaf266)] [nodejs#12995](nodejs#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](nodejs@a16b570f8c)] [nodejs#11968](nodejs#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](nodejs@010f864426)] [nodejs#12949](nodejs#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](nodejs@a5f91ab230)] [nodejs#11689](nodejs#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](nodejs@8a7db9d4b5)] [nodejs#12087](nodejs#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](nodejs@b6e1d22fa6)] [nodejs#12925](nodejs#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](nodejs@07c7f198db)] [nodejs#12828](nodejs#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](nodejs@348cc80a3c)] [nodejs#5923](nodejs#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](nodejs@a2ae08999b)] [nodejs#11349](nodejs#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](nodejs@d523eb9c40)] [nodejs#11447](nodejs#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](nodejs@d080ead0f9)] [nodejs#12710](nodejs#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](nodejs@5bfd13b81e)] [nodejs#9726](nodejs#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](nodejs@455e6f1dd8)] [nodejs#11708](nodejs#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](nodejs@aab0d202f8)] [nodejs#11624](nodejs#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](nodejs@99da8e8e02)] [nodejs#12442](nodejs#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](nodejs@91383e47fd)] [nodejs#12001](nodejs#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](nodejs@b514bd231e)] [nodejs#11391](nodejs#11391).

* **Async Hooks** * The `async_hooks` module has landed in core [[`4a7233c178`](4a7233c178)] [#12892](#12892). * **Buffer** * Using the `--pending-deprecation` flag will cause Node.js to emit a deprecation warning when using `new Buffer(num)` or `Buffer(num)`. [[`d2d32ea5a2`](d2d32ea5a2)] [#11968](#11968). * `new Buffer(num)` and `Buffer(num)` will zero-fill new `Buffer` instances [[`7eb1b4658e`](7eb1b4658e)] [#12141](#12141). * Many `Buffer` methods now accept `Uint8Array` as input [[`beca3244e2`](beca3244e2)] [#10236](#10236). * **Child Process** * Argument and kill signal validations have been improved [[`97a77288ce`](97a77288ce)] [#12348](#12348), [[`d75fdd96aa`](d75fdd96aa)] [#10423](#10423). * Child Process methods accept `Uint8Array` as input [[`627ecee9ed`](627ecee9ed)] [#10653](#10653). * **Console** * Error events emitted when using `console` methods are now supressed. [[`f18e08d820`](f18e08d820)] [#9744](#9744). * **Dependencies** * The npm client has been updated to 5.0.0 [[`3c3b36af0f`](3c3b36af0f)] [#12936](#12936). * V8 has been updated to 5.8 with forward ABI stability to 6.0 [[`60d1aac8d2`](60d1aac8d2)] [#12784](#12784). * **Domains** * Native `Promise` instances are now `Domain` aware [[`84dabe8373`](84dabe8373)] [#12489](#12489). * **Errors** * We have started assigning static error codes to errors generated by Node.js. This has been done through multiple commits and is still a work in progress. * **File System** * The utility class `fs.SyncWriteStream` has been deprecated [[`7a55e34ef4`](7a55e34ef4)] [#10467](#10467). * The deprecated `fs.read()` string interface has been removed [[`3c2a9361ff`](3c2a9361ff)] [#9683](#9683). * **HTTP** * Improved support for userland implemented Agents [[`90403dd1d0`](90403dd1d0)] [#11567](#11567). * Outgoing Cookie headers are concatenated into a single string [[`d3480776c7`](d3480776c7)] [#11259](#11259). * The `httpResponse.writeHeader()` method has been deprecated [[`fb71ba4921`](fb71ba4921)] [#11355](#11355). * New methods for accessing HTTP headers have been added to `OutgoingMessage` [[`3e6f1032a4`](3e6f1032a4)] [#10805](#10805). * **Lib** * All deprecation messages have been assigned static identifiers [[`5de3cf099c`](5de3cf099c)] [#10116](#10116). * The legacy `linkedlist` module has been removed [[`84a23391f6`](84a23391f6)] [#12113](#12113). * **N-API** * Experimental support for the new N-API API has been added [[`56e881d0b0`](56e881d0b0)] [#11975](#11975). * **Process** * Process warning output can be redirected to a file using the `--redirect-warnings` command-line argument [[`03e89b3ff2`](03e89b3ff2)] [#10116](#10116). * Process warnings may now include additional detail [[`dd20e68b0f`](dd20e68b0f)] [#12725](#12725). * **REPL** * REPL magic mode has been deprecated [[`3f27f02da0`](3f27f02da0)] [#11599](#11599). * **Src** * `NODE_MODULE_VERSION` has been updated to 57 (ec7cbaf266)] [#12995](#12995). * Add `--pending-deprecation` command-line argument and `NODE_PENDING_DEPRECATION` environment variable [[`a16b570f8c`](a16b570f8c)] [#11968](#11968). * The `--debug` command-line argument has been deprecated. Note that using `--debug` will enable the *new* Inspector-based debug protocol as the legacy Debugger protocol previously used by Node.js has been removed. [[`010f864426`](010f864426)] [#12949](#12949). * Throw when the `-c` and `-e` command-line arguments are used at the same time [[`a5f91ab230`](a5f91ab230)] [#11689](#11689). * Throw when the `--use-bundled-ca` and `--use-openssl-ca` command-line arguments are used at the same time. [[`8a7db9d4b5`](8a7db9d4b5)] [#12087](#12087). * **Stream** * `Stream` now supports `destroy()` and `_destroy()` APIs [[`b6e1d22fa6`](b6e1d22fa6)] [#12925](#12925). * `Stream` now supports the `_final()` API [[`07c7f198db`](07c7f198db)] [#12828](#12828). * **TLS** * The `rejectUnauthorized` option now defaults to `true` [[`348cc80a3c`](348cc80a3c)] [#5923](#5923). * The `tls.createSecurePair()` API now emits a runtime deprecation [[`a2ae08999b`](a2ae08999b)] [#11349](#11349). * A runtime deprecation will now be emitted when `dhparam` is less than 2048 bits [[`d523eb9c40`](d523eb9c40)] [#11447](#11447). * **URL** * The WHATWG URL implementation is now a fully-supported Node.js API [[`d080ead0f9`](d080ead0f9)] [#12710](#12710). * **Util** * `Symbol` keys are now displayed by default when using `util.inspect()` [[`5bfd13b81e`](5bfd13b81e)] [#9726](#9726). * `toJSON` errors will be thrown when formatting `%j` [[`455e6f1dd8`](455e6f1dd8)] [#11708](#11708). * Convert `inspect.styles` and `inspect.colors` to prototype-less objects [[`aab0d202f8`](aab0d202f8)] [#11624](#11624). * The new `util.promisify()` API has been added [[`99da8e8e02`](99da8e8e02)] [#12442](#12442). * **Zlib** * Support `Uint8Array` in Zlib convenience methods [[`91383e47fd`](91383e47fd)] [#12001](#12001). * Zlib errors now use `RangeError` and `TypeError` consistently [[`b514bd231e`](b514bd231e)] [#11391](#11391).

mscdex added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 29, 2017

nodejs-github-bot added build Issues and PRs related to build files or the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Mar 29, 2017

mscdex removed the build Issues and PRs related to build files or the CI. label Mar 29, 2017

mscdex added the ctc-review label Mar 29, 2017

mscdex mentioned this pull request Mar 29, 2017

linkedlist: remove unused methods #11726

Closed

2 tasks

jasnell approved these changes Mar 29, 2017

View reviewed changes

linkedlist: remove public module

9240e6e

mscdex force-pushed the linklist-removal branch from 8a7832d to 9240e6e Compare March 29, 2017 15:34

cjihrig approved these changes Mar 29, 2017

View reviewed changes

mscdex added this to the 8.0.0 milestone Mar 31, 2017

Trott mentioned this pull request Apr 3, 2017

Node.js Foundation Core Technical Committee (CTC) Meeting 2017-04-05 nodejs/CTC#93

Closed

evanlucas approved these changes Apr 3, 2017

View reviewed changes

targos approved these changes Apr 4, 2017

View reviewed changes

jasnell closed this Apr 4, 2017

mscdex deleted the linklist-removal branch April 4, 2017 20:10

jasnell mentioned this pull request Apr 4, 2017

8.0.0 Release Proposal #12220

Closed

Trott removed the ctc-review label Apr 6, 2017

ChALkeR reviewed May 4, 2017

View reviewed changes

gibfahn mentioned this pull request Jan 24, 2018

doc: mark DEP0002 as end of life #17815

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

linkedlist: remove public module #12113

linkedlist: remove public module #12113

Uh oh!

mscdex commented Mar 29, 2017 •

edited

Loading

Uh oh!

mscdex commented Mar 29, 2017

Uh oh!

Trott commented Mar 29, 2017

Uh oh!

mscdex commented Mar 29, 2017

Uh oh!

Trott commented Mar 29, 2017

Uh oh!

jasnell commented Mar 29, 2017

Uh oh!

evanlucas left a comment

Uh oh!

jasnell commented Apr 4, 2017

Uh oh!

jasnell commented Apr 4, 2017

Uh oh!

jasnell commented Apr 4, 2017

Uh oh!

ChALkeR commented May 4, 2017

Uh oh!

ChALkeR left a comment

Uh oh!

Uh oh!

Uh oh!

linkedlist: remove public module #12113

linkedlist: remove public module #12113

Uh oh!

Conversation

mscdex commented Mar 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

mscdex commented Mar 29, 2017

Uh oh!

Trott commented Mar 29, 2017

Uh oh!

mscdex commented Mar 29, 2017

Uh oh!

Trott commented Mar 29, 2017

Uh oh!

jasnell commented Mar 29, 2017

Uh oh!

evanlucas left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Apr 4, 2017

Uh oh!

jasnell commented Apr 4, 2017

Uh oh!

jasnell commented Apr 4, 2017

Uh oh!

ChALkeR commented May 4, 2017

Uh oh!

ChALkeR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mscdex commented Mar 29, 2017 •

edited

Loading