Skip to content

test: add regex to assert in zlib-write-after-close #11482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test: add regex to assert in zlib-write-after-close #11482

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63221a1
test: add regex argument to assert throw in /test/parallel/test-zlib-…
Feb 21, 2017
7f2f72d
test: cleaning up zlib-write-after-close
Feb 23, 2017
49e528d
test: remove space in paren for lint
Feb 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/parallel/test-zlib-write-after-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ const zlib = require('zlib');
zlib.gzip('hello', common.mustCall(function(err, out) {
const unzip = zlib.createGunzip();
unzip.close(common.mustCall(function() {}));
assert.throws(function() {
unzip.write(out);
});
assert.throws(
function() {
unzip.write(out);
},
/^Error: zlib binding closed$/
Copy link
Member

@jasnell jasnell Feb 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be updated to use the new common.expectsError()

);
}));