Invalid string construction

[PJBoy]

node/src/node_url.cc

Line 164 in a724a9e

return ThrowInvalidURL(realm->env(), input.ToStringView(), nullptr);

ThrowInvalidURL takes an std::optional<std::string> as third parameter. Passing nullptr constructs a std::string from that null pointer, this is undefined behaviour (upgraded to ill-formed in C++23). At a glance, it would seem that std::nullopt was the intended third argument.

[anonrig]

Correct. Contributions are welcome.

[geeksilva97]

Would the change be like this

- return ThrowInvalidURL(realm->env(), input.ToStringView(), nullptr); 
+ return ThrowInvalidURL(realm->env(), input.ToStringView(), std::nullopt); 

If so, could this issue be a good first issue?

[danielmbrasil]

Hey, I'd like to take this on.

[Ali-Adel-Nour]

Can, I take this one if there is no objection?

[danielmbrasil]

Hey @Ali-Adel-Nour, there is an open PR addressing this issue already (#57141).