-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
Closed
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
It seems building addons with VS2015 is not working now. Unfortunately the build output doesn't seem to contain useful information.
I thought we only support Visual Studio >= 2017
now in node-gyp.
Also, looks like this is the reason
https://ci.nodejs.org/job/node-test-binary-windows-native-suites/7515/nodes=win10-vcbt2015-COMPILED_BY-vs2019/console
16:08:09 `C:\\workspace\\node-test-binary-windows-native-suites\\node\\deps\\v8\\include\\v8.h(1426): error C2416: attribute 'deprecated("Use constructor with primitvie C++ types")' cannot be applied in this context [C:\\workspace\\node-test-binary-windows-native-suites\\node\\test\\addons\\02_function_arguments\\build\\addon.vcxproj]\r\n`
Not sure node\\test\\addons\\02_function_arguments
locations.
Originally posted by @gengjiawen in #37330 (comment)
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to build files or the CI.Issues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.