-71 instead of EPROTO error

[DanielRuf]

• Version: 13.6.0
• Platform: Ubuntu
• Subsystem:

It seems with Node 13(.6.0) error codes are numeric now which produces failing snapshot tests and assertions.

Before Node 13: EPROTO
Starting with Node 13: -71

Is there some information about this or was this just a bug and is this already fixed?

    expect(received).toEqual(expected) // deep equality

    - Expected
    + Received

      Object {
    -   "error": "EPROTO",
    +   "error": -71,
        "id": null,
      }

      130 |             });
      131 |             client.on('error', (err) => {
    > 132 |                 expect(err).toEqual({ id: null, error: 'EPROTO' });
          |                             ^
      133 |                 done();
      134 |             });
      135 |             client.Authentication.login(USER.email, USER.password, null);

      at Client.<anonymous> (tests/authentication/authentication.test.js:132:29)
      at Authentication.callback (dist/bundle.cjs.js:164:29)
      at Request._callback (dist/bundle.cjs.js:100:28)
      at self.callback (node_modules/request/request.js:185:22)
      at Request.Object.<anonymous>.Request.onRequestError (node_modules/request/request.js:881:8)

[addaleax]

Can you maybe share more information about how to reproduce this?

[richardlau]

If you're using the errno field it was deliberate: #28140

[DanielRuf]

If you're using the errno field it was deliberate: #28140

Seems this is the cause, yes.

[bnoordhuis]

You should probably check against the .code field now rather than .errno.

[DanielRuf]

We found the culprit. It was caused by another module.

Thanks for the clarificartion and information.
Closing as resolved.

[DanielRuf]

I think what we miss here is some history / deprecation or breaking change info:

https://nodejs.org/api/errors.html#errors_error_errno

At least I see none like in other modules. Only 10 history references for a few errors. But no info about the change. This makes it a bit harder to keep track or understand when it was changed and why.

https://nodejs.org/api/fs.html#fs_fs_open_path_flags_mode_callback

Unless we take a look at the changelog.

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md#2019-10-22-version-1300-current-bethgriggs