-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Closed
Labels
flaky-testIssues and PRs related to the tests with unstable failures on the CI.Issues and PRs related to the tests with unstable failures on the CI.processIssues and PRs related to the process subsystem.Issues and PRs related to the process subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Description
- Version: N/A
- Platform: All
- Subsystem: test,bootstrap
node/test/parallel/test-bootstrap-modules.js
Lines 1 to 14 in 5468509
| /* eslint-disable node-core/required-modules */ | |
| 'use strict'; | |
| // Ordinarily test files must require('common') but that action causes | |
| // the global console to be compiled, defeating the purpose of this test. | |
| // This makes sure no additional files are added without carefully considering | |
| // lazy loading. Please adjust the value if necessary. | |
| const list = process.moduleLoadList.slice(); | |
| const assert = require('assert'); | |
| assert(list.length <= 78, list); |
The test uses a magic number that can only be reasonably found empeericaly. That number also changes depending on what CLI parameters are used, or if run with a test harness.
Some suggestions for improvement have been:
- blacklist some modules that we know we don’t want to have loaded unconditionally, rather than set a fixed number. (@addaleax)
- Just reports from the CI or add something informative to the test runner output. (@devsnek)
- ???
Refs: #23876
Metadata
Metadata
Assignees
Labels
flaky-testIssues and PRs related to the tests with unstable failures on the CI.Issues and PRs related to the tests with unstable failures on the CI.processIssues and PRs related to the process subsystem.Issues and PRs related to the process subsystem.testIssues and PRs related to the tests.Issues and PRs related to the tests.