misc: Add Python v3.12 to the testing #2862
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
approved these changes
May 29, 2023
cclauss
force-pushed
the
Test-Python-v3.12-beta
branch
from
880cc99 to
52495cf
Compare
cclauss
force-pushed
the
Test-Python-v3.12-beta
branch
from
b54123d to
7aad092
Compare
cclauss
changed the title
cclauss
changed the title
cclauss
force-pushed
the
Test-Python-v3.12-beta
branch
from
0a16638 to
6d25770
Compare
Contributor
Author
|
@Trott Any ideas on the Windows test failures (tests on Py3.8 and VS tests too)? |
Member
Those failures aren't on the main branch (as far as I can tell), so I'd guess they're related to the changes here. But I say that knowing very little about compiling thingson Windows, etc..... |
cclauss
changed the title
Contributor
Author
|
Closing in favor of nodejs/gyp-next#201 and nodejs/gyp-next#214 as discussed at #2888 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #2869Checklist
npm install && npm testpassesDescription of change