feat(gyp): update gyp to v0.12.1 #2642
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2022
richardlau
approved these changes
Apr 13, 2022
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
LGTM. We could jump straight to gyp-next 0.12.1.
dmabupt
changed the title
Author
Hello @richardlau , I have updated it to v0.12.1. But there are lots of ci failures. |
Author
|
Duplicated PR -- nodejs/node@b99bb57 |
Member
but that PR is on nodejs/node, not nodejs/node-gyp, so I think we're still in need of a gyp-next upgrade here aren't we? |
Contributor
|
Yes, we still need this PR. @dmabupt can you please re-open? |
gengjiawen
requested changes
May 11, 2022
Member
gengjiawen
left a comment
gengjiawen
left a comment
There was a problem hiding this comment.
Need to sync with gyp-next, not nodejs/node gyp folder. Currently they are not align.
Contributor
|
This can be closed in favor of #2626, which now also updates gyp from gyp-next 0.13.0 |
Author
|
Close this issue due to #2626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #2626