Skip to content

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Oct 11, 2021

close #2520

Related: #2493

@gengjiawen gengjiawen requested review from cclauss and rvagg October 11, 2021 09:45
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengjiawen gengjiawen merged commit 5585792 into nodejs:master Oct 11, 2021
@gengjiawen gengjiawen deleted the bump_gyp branch October 11, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Could not find any Visual Studio installation to use (VS2022 Preview)

3 participants