v8: fix V8 upgrades from 7.4 #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Just increment NODE_MODULE_VERSION automatically by one. Now that this constant can also be used by embedders, it is no longer predictable - Add a --no-version-bump so we can skip this task for canary builds. - From V8 7.4 on, gypfiles are located in tools/ instead of deps/v8. Stop trying to move them around.
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 75.75% 75.75%
=======================================
Files 21 21
Lines 1365 1365
=======================================
Hits 1034 1034
Misses 331 331Continue to review full report at Codecov.
|
refack
reviewed
Mar 29, 2019
lib/update-v8/gypfiles.js
Outdated
| @@ -5,7 +5,11 @@ const path = require('path'); | |||
| const fs = require('fs-extra'); | |||
|
|
|||
| function nodeOwnsGypfiles(ctx) { | |||
| if (ctx.currentVersion[0] === 6 && ctx.currentVersion[1] < 6) { | |||
| if ( | |||
There was a problem hiding this comment.
Suggested change
| if ( | |
| const hasGypFiles = fs.exists(path.join(ctx.nodeDir, 'deps/v8/gypfiles')); | |
| if (!hasGypFiles) { | |
| return false; | |
| } | |
| const [v8_major, v8_minor, ...] = ctx.currentVersion; | |
| if (v8_major >= 7 || (v8_minor === 6 && v8_minor > 5)) { | |
| return true; | |
| } | |
| return false; |
There was a problem hiding this comment.
I went for a more drastic change and removed this code entirely. We won't do major upgrades anymore on the current release lines so in the future gypfiles will always be in tools
There was a problem hiding this comment.
removed this code entirely.
💚
refack
approved these changes
Mar 29, 2019
joyeecheung
approved these changes
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this constant can also be used by embedders, it is no longer
predictable
Stop trying to move them around.