Skip to content

ci: handle node-test-commit-custom-suites-freestyle #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2018

Conversation

joyeecheung
Copy link
Member

No description provided.

@@ -16,7 +16,7 @@ const {

const {
PRBuild, BenchmarkRun, CommitBuild, listBuilds
, jobCache
// , jobCache
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously accidentally committed and should be reverted

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #269 into master will decrease coverage by 0.04%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage    79.9%   79.86%   -0.05%     
==========================================
  Files          22       22              
  Lines        1289     1291       +2     
==========================================
+ Hits         1030     1031       +1     
- Misses        259      260       +1
Impacted Files Coverage Δ
lib/ci/ci_result_parser.js 61.73% <75%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9204a87...f8e0d50. Read the comment docs.

@joyeecheung
Copy link
Member Author

CI is green so I'll go ahead and merge this.

@joyeecheung joyeecheung merged commit 0b9a09c into nodejs:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant